Group Admins

  • Profile picture of Boone Gorges

buddypress.org Ninjas

Public Group active 1 week, 6 days ago ago

Dedicated to the squashing of bugs and the blooming of features on buddypress.org

The fixes have begun: activity permalinks (15 posts)

Started 1 year, 5 months ago by: Boone Gorges

  • Profile picture of Boone Gorges Boone Gorges said 1 year, 5 months ago:

    Great news! The first ninja fix is live on buddypress.org. Check out this link: http://buddypress.org/community/activity/p/49614/

    Those activity permalinks were previously broken, which meant that, among other things, the emails notifying you of new @-mentions had unusable links. It’s now been patched, and activity permalinks are redirecting correctly.

    For those who are interested, the problem has to do with the WP pages support in the 1.3-branch. Related ticket: http://trac.buddypress.org/ticket/2600

    Onward and upward!

  • Profile picture of hnla hnla said 1 year, 5 months ago:

    Oh yes yes yes, starting to feel like one can actually track around the site. : ) Thanks Boone

  • Profile picture of Paul Gibbs Paul Gibbs said 1 year, 5 months ago:

    Good job!

  • Profile picture of r-a-y r-a-y said 1 year, 5 months ago:

    Boone, you are the shinobi!

  • Profile picture of pcwriter pcwriter said 1 year, 5 months ago:

    Thank you. Those email links were driving me nuts.
    Well… not nuts really, but it was a bit irritating to have to search through pages of comments to find the one mentioned in an email.

    Good job!

  • Profile picture of Jeff Sayre Jeff Sayre said 1 year, 5 months ago:

    This now means that I actually will have to follow the links. ;) Good job!

  • Profile picture of @mercime @mercime said 1 year, 5 months ago:

    Kudos!

  • Profile picture of Pisanojm Pisanojm said 1 year, 5 months ago:

    Yes!

  • Profile picture of Anointed Anointed said 1 year, 5 months ago:

    stupid question:
    I am using bp 1.2.5trunk which I update every couple of days.

    Is this fix and the others in this branch or just the 1.3 branch?

    –I tried installing 1.3 but it just puked all over itself, so as JJJ suggested I went to the 1.2.5trunk instead.

  • Profile picture of r-a-y r-a-y said 1 year, 5 months ago:

    Boone’s fix isn’t in 1.3 trunk; bp.org is running a customized build of 1.3 at the moment.

    Like JJJ mentioned, stick to 1.2 branch until 1.3 gets some merge love in the coming months.

  • Profile picture of Boone Gorges Boone Gorges said 1 year, 5 months ago:

    @r-a-y is right – the fix isn’t relevant for the 1.2 branch.

  • Profile picture of Travel-Junkie Travel-Junkie said 1 year, 5 months ago:

    Nice! Any chance on getting my hands on the fix? Been developing a site that uses a couple custom plugins that are dependent on BP1.3 .

  • Profile picture of Boone Gorges Boone Gorges said 1 year, 5 months ago:

    @travel-junkie For this site, I just hardcoded the word ‘activity’ to account for funky custom slugs. See http://trac.buddypress.org/ticket/2600. The fix on buddypress.org is in the spirit of the first item under “Possible fixes”; I unhooked the default activity permalink redirector and rehooked one with the change. (Not ideal in the long run, btw, but fine for a single site.)

  • Profile picture of Travel-Junkie Travel-Junkie said 1 year, 5 months ago:

    Oh, ok, cheers for that!!

  • Profile picture of paulhastings0 paulhastings0 said 1 year, 5 months ago:

    :cheers wildly: